fix: Handle optional language tag in header
#497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
approved these changes
Nov 4, 2024
Fixes: KEYMAN-COM-1CX
darcywong00
force-pushed
the
fix/language-undefined
branch
from
2591a9c
to
7b2d69c
Compare
|
Force push to fixup the commit msg for closing the Sentry issue |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #489 fixes #496 and fixes KEYMAN-COM-1CX
where
$fields->languagewas undefined.This also propagates the optional header
languageif it's set. I would expect most pages fallback toenkeyman.com/_includes/2020/templates/Head.php
Lines 16 to 18 in 64bfdfd